Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial AppDirectory POCOs. #58

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Initial AppDirectory POCOs. #58

merged 6 commits into from
Sep 15, 2023

Conversation

fhubi
Copy link
Contributor

@fhubi fhubi commented Sep 11, 2023

No description provided.

@fhubi fhubi requested a review from a team September 11, 2023 16:43
@fhubi fhubi assigned fhubi, bingenito and psmulovics and unassigned fhubi Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #58 (6b270f8) into main (6d47915) will decrease coverage by 5.45%.
The diff coverage is 71.91%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   88.47%   83.02%   -5.45%     
==========================================
  Files          35       47      +12     
  Lines         295      383      +88     
==========================================
+ Hits          261      318      +57     
- Misses         34       65      +31
Files Changed Coverage Δ
...c/Fdc3.AppDirectory/AppDetails/CitrixAppDetails.cs 0.00% <0.00%> (ø)
...c/Fdc3.AppDirectory/AppDetails/NativeAppDetails.cs 0.00% <0.00%> (ø)
....AppDirectory/AppDetails/OnlineNativeAppDetails.cs 0.00% <0.00%> (ø)
...3.NewtonsoftJson/Serialization/Fdc3AppConverter.cs 41.66% <41.66%> (ø)
src/Fdc3.AppDirectory/Fdc3App.cs 93.33% <93.33%> (ø)
src/Fdc3.AppDirectory/AppChannel.cs 100.00% <100.00%> (ø)
src/Fdc3.AppDirectory/AppDetails/WebAppDetails.cs 100.00% <100.00%> (ø)
src/Fdc3.AppDirectory/IntentMetadata.cs 100.00% <100.00%> (ø)
src/Fdc3.AppDirectory/Intents.cs 100.00% <100.00%> (ø)
src/Fdc3.AppDirectory/Interop.cs 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

BalassaMarton
BalassaMarton approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@BalassaMarton BalassaMarton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few unimportant comments to this beautiful PR :)

src/Fdc3.AppDirectory/FDC3App.cs Outdated Show resolved Hide resolved
src/Tests/MorganStanley.Fdc3.AppDirectory.Tests/DeserializationTest.cs Show resolved Hide resolved
src/Fdc3.NewtonsoftJson/Serialization/Fdc3AppDetailsConverter.cs Outdated Show resolved Hide resolved
kruplm
kruplm previously approved these changes Sep 13, 2023
View reviewed changes
@kruplm kruplm requested review from BalassaMarton and a team September 13, 2023 13:27
BalassaMarton
BalassaMarton previously approved these changes Sep 13, 2023
View reviewed changes
@BalassaMarton
Copy link
Contributor

BalassaMarton commented Sep 15, 2023 •
edited
Loading

One last thought: shouldn't we make Fdc3App and related types immutable? After all, AppD is read-only, so we shouldn't see any mutable properties in the data structures it returns.

@bingenito bingenito mentioned this pull request Sep 15, 2023
Merged
BalassaMarton
BalassaMarton previously approved these changes Sep 15, 2023
View reviewed changes
@fhubi fhubi merged commit 8d709bb into finos:main Sep 15, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingenito bingenito bingenito approved these changes

@BalassaMarton BalassaMarton BalassaMarton left review comments

@kruplm kruplm kruplm left review comments

Assignees

@bingenito bingenito

@psmulovics psmulovics

@kruplm kruplm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fhubi @BalassaMarton @bingenito @kruplm @psmulovics